Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityFilter: add peristent storage and Unpaid filter #1381

Merged
merged 9 commits into from
Mar 19, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Mar 16, 2023

Description

Relates to issues:
ZEUS-1325
ZEUS-1327
ZEUS-1330

This PR adds several enhancements to the ActivityFilter:

  • Filters are now persistent across sessions and are saved to local stoage
  • There is now a Unpaid toggle on the ActivityFilter so that users can filter out unpaid invoices
  • The Channels toggle has been removed. It was used for filtered out 0 amt transactions LND used to create prior to anchor outputs.
  • You can now clear your filters by pressing the X button in the top right corner of the ActivityFilter view

Simulator Screen Shot - iPad Pro (12 9-inch) (6th generation) - 2023-03-16 at 20 55 32

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis changed the title ActivityFilter: add toggle for Unpaid ActivityFilter: add peristence and toggle for Unpaid Mar 17, 2023
@kaloudis kaloudis changed the title ActivityFilter: add peristence and toggle for Unpaid ActivityFilter: add peristent storage and Unpaid filter Mar 17, 2023
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filters are not working, getting 0 sats transaction history for all filters.

@kaloudis kaloudis merged commit 5a3c82b into ZeusLN:master Mar 19, 2023
@kaloudis kaloudis deleted the activity-filter-unpaid branch March 19, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants